Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity
Date: 2018-01-03 23:36:07
Message-ID: 32747.1515022567@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> If there is any system where sizeof(FormData_pg_attribute) !=
> (offsetof(FormData_pg_attribute,attcollation) + sizeof(Oid)), won't
> load_relcache_init_file() get upset? Oh, I see it would just go to
> read_failed and then "do it the hard way".

Right, so we needn't include a catversion bump (or more likely,
a RELCACHE_INIT_FILEMAGIC change) in that patch.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-01-03 23:38:53 January CommitFest is underway!
Previous Message Thomas Munro 2018-01-03 23:31:41 Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity