Re: [PATCH] Fix overflow and underflow in regr_r2()

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chengpeng Yan <chengpeng_yan(at)outlook(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, rmt(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Fix overflow and underflow in regr_r2()
Date: 2026-05-16 16:31:52
Message-ID: CAEZATCW_4XrQyN95fFjBGh7=uyU8wbUN7eQzwSd5Z8-FvANSPw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 16 May 2026 at 14:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> > Attached is a v2 patch with those changes, plus a little more tidying
> > up of the regression tests.
>
> LGTM.

Thanks for looking.

> > Arguably, this is a bug fix, but given the lack of prior complaints, I
> > think we should apply this to HEAD only, like 6498287696d, meaning it
> > will only appear in PG19.
>
> Agreed on no back-patch. It seems sensible to slip this into v19
> rather than wait for v20, since the corresponding fix in corr()
> is new as of 19. But since that's a judgment call, maybe you should
> get the concurrence of the RMT.

Yes, that was my thinking. Does anyone from the RMT (cc'ed) have any
objection to slipping this into v19?

Regards,
Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hüseyin Demir 2026-05-16 16:37:31 Re: Checkpoint replication slots later
Previous Message Xuneng Zhou 2026-05-16 16:25:20 Re: Bound memory usage during manual slot sync retries