Re: [PATCH] Fix overflow and underflow in regr_r2()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Chengpeng Yan <chengpeng_yan(at)outlook(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix overflow and underflow in regr_r2()
Date: 2026-05-16 13:39:24
Message-ID: 1494820.1778938764@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> Attached is a v2 patch with those changes, plus a little more tidying
> up of the regression tests.

LGTM.

> Arguably, this is a bug fix, but given the lack of prior complaints, I
> think we should apply this to HEAD only, like 6498287696d, meaning it
> will only appear in PG19.

Agreed on no back-patch. It seems sensible to slip this into v19
rather than wait for v20, since the corresponding fix in corr()
is new as of 19. But since that's a judgment call, maybe you should
get the concurrence of the RMT.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-05-16 13:42:47 Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10
Previous Message Alexander Lakhin 2026-05-16 13:00:00 Re: SQL Property Graph Queries (SQL/PGQ)