| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WITH CHECK and Column-Level Privileges |
| Date: | 2015-01-28 08:46:13 |
| Message-ID: | CAEZATCWGVzoWAre4tdmu0Dwa-SKOSS-3ckZcEnDuT-O3macihQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27 January 2015 at 22:45, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Here's the latest set with a few additional improvements (mostly
> comments but also a couple missed #include's and eliminating unnecessary
> whitespace changes). Unless there are issues with my testing tonight or
> concerns raised, I'll push these tomorrow.
>
I spotted a couple of minor things reading the patches:
- There's a typo in the comment for the GetModifiedColumns() macros
("...stick in into...").
- The new regression test is not tidying up properly after itself,
because it's trying to drop the table t1 as the wrong user.
Other than that, this looks reasonable to me, and I think that for
most common situations it won't reduce the detail in errors.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2015-01-28 09:05:30 | Re: EvalPlanQual behaves oddly for FDW queries involving system columns |
| Previous Message | Kyotaro HORIGUCHI | 2015-01-28 08:41:12 | Re: TABLESAMPLE patch |