From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WITH CHECK and Column-Level Privileges |
Date: | 2015-01-28 16:19:34 |
Message-ID: | 20150128161934.GX3854@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dean,
* Dean Rasheed (dean(dot)a(dot)rasheed(at)gmail(dot)com) wrote:
> On 27 January 2015 at 22:45, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > Here's the latest set with a few additional improvements (mostly
> > comments but also a couple missed #include's and eliminating unnecessary
> > whitespace changes). Unless there are issues with my testing tonight or
> > concerns raised, I'll push these tomorrow.
>
> I spotted a couple of minor things reading the patches:
>
> - There's a typo in the comment for the GetModifiedColumns() macros
> ("...stick in into...").
Fixed.
> - The new regression test is not tidying up properly after itself,
> because it's trying to drop the table t1 as the wrong user.
Urgh. Not sure how I managed to miss that; guess I was just too focused
on what I was testing. :)
> Other than that, this looks reasonable to me, and I think that for
> most common situations it won't reduce the detail in errors.
Thanks! I'll be pushing this soon (finally!).
Thanks again,
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-01-28 16:50:33 | Re: PQgetssl() and alternative SSL implementations |
Previous Message | Andres Freund | 2015-01-28 16:08:46 | Re: Misaligned BufferDescriptors causing major performance problems on AMD |