| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows |
| Date: | 2026-07-15 18:51:28 |
| Message-ID: | CAEZATCWEsMTVTA4mOPidvPE4wEv=oVzurR+vSAPmeT4RS7FqCg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2 Jul 2026 at 22:57, Paul A Jungwirth
<pj(at)illuminatedcomputing(dot)com> wrote:
>
> On Thu, Jul 2, 2026 at 2:52 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> > PFA v3, only this tiny doc change.
>
> +1
>
This should also update the doc table "Policies Applied by Command
Type" on the CREATE POLICY page. I'd suggest a new row for "UPDATE ...
FOR PORTION OF" immediately after the "UPDATE" row, rather than trying
to reuse the existing row with more conditions (and similarly for
DELETE).
Also, in the rowsecurity regression test, it would be a good idea to
add test cases to the "Test policies applied by command type" section.
Those tests are the confirmations that what that doc table says is
true (the patch's tests aren't really checking that the SELECT policy
is being applied, for example).
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-07-15 18:55:25 | Re: [PATCH] pgbench: fix incorrect long option name in error message |
| Previous Message | surya poondla | 2026-07-15 18:48:35 | Re: [DESIGN] Soft DROP TABLE, recoverable drops for PostgreSQL |