| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows |
| Date: | 2026-07-15 21:02:10 |
| Message-ID: | CA+renyX5Mk7oq-S2eX1q7656ThtynmN5J9TWp2fSvWuMPivPjA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2026 at 11:51 AM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> This should also update the doc table "Policies Applied by Command
> Type" on the CREATE POLICY page. I'd suggest a new row for "UPDATE ...
> FOR PORTION OF" immediately after the "UPDATE" row, rather than trying
> to reuse the existing row with more conditions (and similarly for
> DELETE).
>
> Also, in the rowsecurity regression test, it would be a good idea to
> add test cases to the "Test policies applied by command type" section.
> Those tests are the confirmations that what that doc table says is
> true (the patch's tests aren't really checking that the SELECT policy
> is being applied, for example).
Thanks for taking a look! Here is a v4 with those additions.
Yours,
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-RLS-checks-for-FOR-PORTION-OF-leftover-rows.patch | text/x-patch | 16.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-07-15 21:09:30 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |
| Previous Message | Sami Imseih | 2026-07-15 20:50:19 | pgstat: add pgstat_prep_pending() for entry ref pending setup |