| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> |
| Cc: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding error messages to a few slash commands |
| Date: | 2025-07-01 11:03:11 |
| Message-ID: | CAEZATCW7k3GO8w3NBaZFHoKBE8oiC_7ryG-Eayi5EAy9pOAxoQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 13 Apr 2025 at 17:40, Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> wrote:
>
> Thanks for the feedback, attached an updated patch that changes most
> of those "Did not find" messages to empty tables. I did not change two
> sets, listDbRoleSettings and listTables both have comments describing
> that these are deliberately this way.
>
+1 for always displaying an empty table if no objects are found.
The reason given for listDbRoleSettings() being an exception could be
solved by making the title depend on the number of arguments, e.g.,
"List of settings for role \"%s\" and database \"%s\".".
It's not clear what the "historical reasons" are for listTables()
being an exception, but if we're changing any of these, I'd say we
should make them all consistent.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-07-01 11:03:28 | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Previous Message | Álvaro Herrera | 2025-07-01 10:54:41 | Re: back-patch documentation for age() and mxid_age() |