Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, Joel Jacobson <joel(at)compiler(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to>
Subject: Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2
Date: 2025-06-25 11:39:08
Message-ID: CAEZATCV0Xpo4QHkpa66GtA_frfGpaJcK3ua6mSKhb3SQd=xAuQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 12 May 2025 at 19:33, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>
> I have fixed that one and some other issues locally and will submit a
> new version in a while after I have added more tests because you are
> very correct in that a big issue with my last version of the patch was
> the big lack of tests and lack of making sure all features which
> interact with UPSERT actually worked with my changes. Plus some islation
> tests would be nice to have.
>

+1. Don't forget to move the CF entry to the next open CF.

FYI, over on [1] I proposed more tests and doc updates for RLS. I
think those updates might make it easier to test and document the RLS
aspects of this patch.

[1] https://www.postgresql.org/message-id/flat/CAEZATCWqnfeChjK=n1V_dYZT4rt4mnq+ybf9c0qXDYTVMsy8pg(at)mail(dot)gmail(dot)com

Regards,
Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-06-25 11:46:07 Re: pg_dump misses comments on NOT NULL constraints
Previous Message Matheus Alcantara 2025-06-25 11:36:46 Re: SCRAM pass-through authentication for postgres_fdw