Re: pg_dump misses comments on NOT NULL constraints

On 2025-Jun-25, Fujii Masao wrote:

> From 516e647e7d1fdafc64dba092389963f32cd688e5 Mon Sep 17 00:00:00 2001
> From: Fujii Masao <fujii(at)postgresql(dot)org>
> Date: Wed, 25 Jun 2025 10:02:56 +0900
> Subject: [PATCH v2] Make CREATE TABLE LIKE copy comments on NOT NULL
> constraints when requested.
>
> Commit 14e87ffa5c5 introduced support for adding comments to NOT NULL
> constraints. However, CREATE TABLE LIKE INCLUDING COMMENTS did not copy
> these comments to the new table. This was an oversight in that commit.
>
> This commit corrects the behavior by ensuring CREATE TABLE LIKE to also copy
> the comments on NOT NULL constraints when INCLUDING COMMENTS is specified.

LGTM. I'd add a line in the test showing that these comments are copied
even if INCLUDING CONSTRAINTS is not given, because not-null constraints
comments themselves are -- as attached.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"It takes less than 2 seconds to get to 78% complete; that's a good sign.
A few seconds later it's at 90%, but it seems to have stuck there. Did
somebody make percentages logarithmic while I wasn't looking?"
http://smylers.hates-software.com/2005/09/08/1995c749.html