| From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Date: | 2017-08-07 13:43:37 |
| Message-ID: | CAEP4nAwfp6=h6CnMdaV91BrOeAuuEnfMPBCLyRLo2J1eEoC7ag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 July 2017 at 05:14, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
>
> On 20 July 2017 at 05:08, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>
>> On Wed, Jul 19, 2017 at 8:59 PM,
>>
>> Fabrízio de Royes Mello
>> > You should add the properly sgml docs for this pg_dumpall change also.
>>
>> Tests of pg_dump go to src/bin/pg_dump/t/ and tests for objects in
>> extensions are in src/test/modules/test_pg_dump, but you just care
>> about the former with this patch. And if you implement some new tests,
>> look at the other tests and base your work on that.
>>
>
> Thanks Michael /
>
> Fabrízio.
>
> Updated patch (attached) additionally adds SGML changes for pg_dumpall.
> (I'll try to work on the tests, but sending this
>
> nonetheless
> ).
>
>
Attached is an updated patch (v4) with basic tests for pg_dump / pg_dumpall.
(Have zipped it since patch size jumped to ~40kb).
-
robins
| Attachment | Content-Type | Size |
|---|---|---|
| pgdump_nocomments_v4.zip | application/zip | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-08-07 13:46:56 | Re: Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION |
| Previous Message | Tom Lane | 2017-08-07 13:37:30 | Re: Adding hook in BufferSync for backup purposes |