From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION |
Date: | 2017-08-07 13:46:56 |
Message-ID: | 0ee6bf2c-25a1-2728-ad54-9d6c72dd24b4@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 7/27/17 20:51, Yugo Nagata wrote:
> When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is
> an unkown table at local, it says;
>
> NOTICE: added subscription for table public.tbl
>
> I feel this a bit misleading because it says a subscription is added
> but actually new subscription object is not created. Of cause, I can
> understand the intention this message says, but I feel that
> it is better to use other expression. For example, how about saying
>
> NOTICE: table public.tbl is added to subscription sub1
>
> as proposed in the attached patch. This also fixes the message
> when a table is removed from a subscription.
Fixed, thanks. (Note that per another discussion, these are now DEBUG
messages.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2017-08-07 13:49:34 | Re: free space % calculation in pgstathashindex |
Previous Message | Robins Tharakan | 2017-08-07 13:43:37 | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |