Re: A WalSnd issue related to state WALSNDSTATE_STOPPING

From: Paul Guo <pguo(at)pivotal(dot)io>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: A WalSnd issue related to state WALSNDSTATE_STOPPING
Date: 2018-11-27 02:07:04
Message-ID: CAEET0ZFr00MLhC-auSfszZ+LrbV5H1N0VNqeCn8oJ7PQbW9joA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> On Thu, Nov 22, 2018 at 06:31:04PM +0800, Paul Guo wrote:
> > Yes, please see the attached patch.
>
> Thanks, I have reviewed your patch, and could not resist to change
> SyncRepReleaseWaiters() on top of the rest with a comment to not be
> confused about the WAL sender states allowed to release waiters.
>
> The previous experience is proving that it seems unwise to rely on the
> order of the elements in WalSndState, so I have tweaked things so as the
> state is listed for all the code paths involved.
>
> Paul, what do you think?
> --
> Michael
>

Agree. Your code change is safer.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2018-11-27 02:25:50 Re: [HACKERS] Block level parallel vacuum
Previous Message Andres Freund 2018-11-27 01:55:57 Re: Pluggable Storage - Andres's take