| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Page Scan Mode in Hash Index |
| Date: | 2017-03-23 18:35:49 |
| Message-ID: | CAE9k0Pn9sSphjM1ARr5Z=OUyOHNTFbckT84ms6i+xBratd88sw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Hi,
>
> On 03/23/2017 02:11 PM, Ashutosh Sharma wrote:
>>
>> On Thu, Mar 23, 2017 at 8:29 PM, Jesper Pedersen
>> <jesper(dot)pedersen(at)redhat(dot)com> wrote:
>>>
>>> 0001v2:
>>>
>>> In hashgettuple() you can remove the 'currItem' and 'offnum' from the
>>> 'else'
>>> part, and do the assignment inside
>>>
>>> if (so->numKilled < MaxIndexTuplesPerPage)
>>>
>>> instead.
>>>
>>
>> Done. Please have a look into the attached v3 patch.
>>
>>>
>>> No new comments for 0002 and 0003.
>>
>>
>> okay. Thanks.
>>
>
> I'll keep the entry in 'Needs Review' if Alexander, or others, want to add
> their feedback.
okay. Thanks.
>
> (Best to post the entire patch series each time)
I take your suggestion. Please find the attachments.
--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rewrite-hash-index-scans-to-work-a-page-at-a-timev3.patch | application/x-patch | 23.7 KB |
| 0002-Remove-redundant-function-_hash_step-and-some-of-the.patch | application/x-patch | 8.4 KB |
| 0003-Improve-locking-startegy-during-VACUUM-in-Hash-Index.patch | application/x-patch | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-03-23 18:42:43 | Re: Hash support for grouping sets |
| Previous Message | Robert Haas | 2017-03-23 18:29:39 | Re: [PATCH] Transaction traceability - txid_status(bigint) |