| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Page Scan Mode in Hash Index |
| Date: | 2017-03-23 18:19:12 |
| Message-ID: | 926e3104-8fb0-9d2d-e0b3-c3efd7c8bc3a@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 03/23/2017 02:11 PM, Ashutosh Sharma wrote:
> On Thu, Mar 23, 2017 at 8:29 PM, Jesper Pedersen
> <jesper(dot)pedersen(at)redhat(dot)com> wrote:
>> 0001v2:
>>
>> In hashgettuple() you can remove the 'currItem' and 'offnum' from the 'else'
>> part, and do the assignment inside
>>
>> if (so->numKilled < MaxIndexTuplesPerPage)
>>
>> instead.
>>
>
> Done. Please have a look into the attached v3 patch.
>
>>
>> No new comments for 0002 and 0003.
>
> okay. Thanks.
>
I'll keep the entry in 'Needs Review' if Alexander, or others, want to
add their feedback.
(Best to post the entire patch series each time)
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2017-03-23 18:22:10 | Re: Hash support for grouping sets |
| Previous Message | Mithun Cy | 2017-03-23 18:14:12 | Re: Patch: Write Amplification Reduction Method (WARM) |