Re: Reduce logging during prepared transaction recovery

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Reduce logging during prepared transaction recovery
Date: 2026-10-28 10:14:46
Message-ID: CAE9k0Pn-ibb7=71uEusWW9grb0AW+PPNAHw_DX5W2HNXKc08RA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fujii-san,

On Mon, Oct 19, 2026 at 8:55 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Sat, Oct 17, 2026 at 11:32 PM Pierre Forstmann
> <pierre(dot)forstmann(at)gmail(dot)com> wrote:
> >
> > The following review has been posted through the commitfest application:
> > make installcheck-world: tested, passed
> > Implements feature: tested, passed
> > Spec compliant: not tested
> > Documentation: not tested
> >
> > Hello,
> >
> > This patch looks good to me.
>
> +1. I have one small suggestion, though.
>
> The existing TAP test 009_twophase.pl already tests server startup with
> prepared transactions. So, isn't it better to add the log checks there,
> as in the attached patch?
>

Thanks for the review and suggestions. I agree that we can verify
these changes by adding log checks to the existing TAP test for
two-phase transactions. I’ve done that in the attached patch, which is
based on the changes suggested in your earlier patch. Please take a
look and let me know if you have any other comments.

--
With Regards,
Ashutosh Sharma.

Attachment Content-Type Size
v2-0001-Reduce-logging-during-prepared-transaction-recovery.patch application/octet-stream 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2026-10-28 10:45:53 Re: SQL/JSON DEFAULT ON ERROR/ON EMPTY evaluation fail should rethrow error unconditionally
Previous Message David Rowley 2026-10-28 09:55:01 Re: [PATCH] Remove useless ORDER BY from scalar subqueries