| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Page Scan Mode in Hash Index |
| Date: | 2017-09-21 04:55:27 |
| Message-ID: | CAE9k0Pktn1CSmxnzj=z1CkFCbd1vXrtPe7nzadiiBwnDFDVQpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 21, 2017 at 9:30 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 20, 2017 at 11:43 AM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>> Attached are the patches with above changes. Thanks.
>
> Thanks. I think that the comments and README changes in 0003 need
> significantly more work. In several places, they fail to note the
> unlogged vs. logged differences, and the header comment for
> hashbucketcleanup still says that scans depend on increasing-TID order
> (really, 0001 should change that text somehow).
>
Thanks for putting that point. I will try to correct the comments in
hashbucketcleanup(), mention about the handling done for logged and
unlogged tables in README and submit the updated patch asap.
--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-09-21 05:20:11 | Re: pgbench: Skipping the creating primary keys after initialization |
| Previous Message | Robert Haas | 2017-09-21 04:00:12 | Re: Page Scan Mode in Hash Index |