Re: [PATCH] Improve geometric types

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: [PATCH] Improve geometric types
Date: 2018-07-10 17:36:41
Message-ID: CAE2gYzxvUBzOtTsUhVJmX+2EQvPoH55fTRmxOC1COB=DpCJpMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> Now I understand what you mean. win32_port.h defines isnan(x) as
> _isnan(x) if (_MSC_VER < 1800). It doesn't look right to have the
> definition in here but not include <float.h> as _isnan() is coming
> from there. I am preparing an additional patch to add the include and
> remove it from files where it is obviously put to work around this
> problem.

I posted this to another thread. Until this is sorted out I made the
new float header patch include <float.h>, so they are not dependent.
New versions are attached.

Attachment Content-Type Size
0001-geo-funcs-v10.patch application/octet-stream 100.3 KB
0002-float-header-v14.patch application/octet-stream 84.4 KB
0003-geo-float-v11.patch application/octet-stream 86.5 KB
0004-line-fixes-v10.patch application/octet-stream 12.9 KB
0005-float-zero-v06.patch application/octet-stream 2.9 KB
0006-geo-tests-v06.patch application/octet-stream 406.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-10 17:51:29 Re: _isnan() on Windows
Previous Message Emre Hasegeli 2018-07-10 17:36:39 _isnan() on Windows