From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Subject: | Re: [PATCH] Improve geometric types |
Date: | 2018-07-10 09:32:27 |
Message-ID: | CAE2gYzw4K5zVViXDdCKg7ZNY2+47s1gg5Fd4g8xj5a86jQpLSQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> The version number restriction isn't strictly needed. I only
> suggested it because it'd match the #if that wraps the code that's
> actually using those macros, introduced by commit cec8394b5ccd. That
> was presumably done because versions >= 1800 (= Visual Studio 2013)
> have their own definitions of isinf() and isnan(), and I guess that
> our definitions were probably breaking stuff on that compiler.
Now I understand what you mean. win32_port.h defines isnan(x) as
_isnan(x) if (_MSC_VER < 1800). It doesn't look right to have the
definition in here but not include <float.h> as _isnan() is coming
from there. I am preparing an additional patch to add the include and
remove it from files where it is obviously put to work around this
problem.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-07-10 09:33:20 | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |
Previous Message | Ants Aasma | 2018-07-10 09:21:53 | Re: Recovery performance of standby for multiple concurrent truncates on large tables |