| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: _isnan() on Windows |
| Date: | 2018-07-10 17:51:29 |
| Message-ID: | 20180710175128.ubudbinw6qr5bwen@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jul-10, Emre Hasegeli wrote:
> isnan() function is evidently not present on <math.h> on Windows
> before Visual Studio 2013. We define it on win32_port.h using
> _isnan(). However _isnan() is also not present. It is on <float.h>.
> The patch is attached to include this from win32_port.h.
>
> Thanks to Thomas Munro for point this out to me [1]. It is hard to
> notice this issue without testing the changes on Windows.
Oh, it looks like commits 33a7101281c6, 8e211f539146, 86dbbf20d849
(probably others) papered over this by the expedient of adding #include
<float.h> to random .c files rather than your patch, which seems the
proper fix.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Patrick Hemmer | 2018-07-10 17:54:12 | performance statistics monitoring without spamming logs |
| Previous Message | Emre Hasegeli | 2018-07-10 17:36:41 | Re: [PATCH] Improve geometric types |