ClosePipeStream failure ignored in pg_import_system_collations

From: Mark Dilger <hornschnorter(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: ClosePipeStream failure ignored in pg_import_system_collations
Date: 2019-05-23 18:29:15
Message-ID: CAE-h2ToRCx5XC3nQqeNipqhTt9berCYVVEvM4vEfkTKUsk9S4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hackers,

I only see three invocations of ClosePipeStream in the sources.
In two of them, the return value is checked and an error is raised
if it failed. In the third, the error (if any) is squashed.

I don't know if a pipe stream over "locale -a" could ever fail to
close, but it seems sensible to log an error if it does.

Thoughts?

mark

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-05-23 18:49:08 Re: FullTransactionId changes are causing portability issues
Previous Message Andres Freund 2019-05-23 18:18:20 Re: fsync failure in durable_unlink ignored in xlog.c?