Re: Simplify code building the LR conflict messages

From: Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify code building the LR conflict messages
Date: 2025-12-03 18:04:02
Message-ID: CADzfLwX7fHaRX5MW1cT2W7f0QXbKcJD55aWTfr3kGO19niLymw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, everyone!

On Wed, Dec 3, 2025 at 3:41 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> I think it's odd that conflict resolution depends on log entries. I
> think it would be much more valuable if conflict reporting would save
> the details of the conflict to some kind of conflict logging table.
> How exactly are we expecting that users would bring the data from the
> log file to a database row, when they are to be merged? What happens if
> there are bytea columns in the table?

Such a proposal exists already at [0].

Also, sorry for being noisy and a little-bit offtopic but I think it
is a good moment to highlight the fact that such messages are also not
so useful because sometimes they are just clearly incorrect...
You may find details and reproducers at [1] and [2].

Best regards,
Mikhail.

[0]: https://www.postgresql.org/message-id/flat/CAA4eK1%2B44b3vd_OWfiaVNtjf5Njb5cek09pmKRmttBByeg0NoA%40mail.gmail.com#e74b1b89039c21e64342a7d337128edb
[1]: https://www.postgresql.org/message-id/flat/CADzfLwXZVmbo11tFS_G2i+6TfFVwHU4VUUSeoqb+8UQfuoJs8A(at)mail(dot)gmail(dot)com
[2]: https://www.postgresql.org/message-id/flat/CADzfLwVj9ogzrf2P_H9Xb1z8vLEzBemBxp1nC9wCg4KaOFbvmw%40mail.gmail.com#41375b3243460a14bfab55bfead9011e

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2025-12-03 18:06:51 Proposal: Add a callback data parameter to GetNamedDSMSegment
Previous Message Ignat Remizov 2025-12-03 18:01:38 Re: [PATCH] Add enable_copy_program GUC to control COPY PROGRAM