Re: Simplify code building the LR conflict messages

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify code building the LR conflict messages
Date: 2025-12-04 06:28:47
Message-ID: CAA4eK1+A9L_fGX-7i9bHLxVzQX=8UuCq9k9o4Hq_oWbxEuxtMQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 3, 2025 at 11:34 PM Mihail Nikalayeu
<mihailnikalayeu(at)gmail(dot)com> wrote:
>
> Hello, everyone!
>
> On Wed, Dec 3, 2025 at 3:41 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > I think it's odd that conflict resolution depends on log entries. I
> > think it would be much more valuable if conflict reporting would save
> > the details of the conflict to some kind of conflict logging table.
> > How exactly are we expecting that users would bring the data from the
> > log file to a database row, when they are to be merged? What happens if
> > there are bytea columns in the table?
>
> Such a proposal exists already at [0].
>

Thanks for providing the information.

> Also, sorry for being noisy and a little-bit offtopic but I think it
> is a good moment to highlight the fact that such messages are also not
> so useful because sometimes they are just clearly incorrect...
> You may find details and reproducers at [1] and [2].
>

Yes, I am aware of those, but IIRC, those are due to the traditional
design choice of using DirtySnapshot during the apply-phase of logical
replication. We need to discuss that separately and come to a
conclusion.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nitin Jadhav 2025-12-04 06:31:24 Re: Fix crash during recovery when redo segment is missing
Previous Message Amit Kapila 2025-12-04 06:27:21 Re: Simplify code building the LR conflict messages