| From: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |
| Date: | 2025-11-30 16:52:00 |
| Message-ID: | CADzfLwUxh7ajjB4z5brOYRPKe=1g+49hb6LSC1k=gbR5QHOPZA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, Álvaro!
On Sun, Nov 30, 2025 at 1:11 PM Mihail Nikalayeu
<mihailnikalayeu(at)gmail(dot)com> wrote:
> On Sat, Nov 29, 2025 at 6:48 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > Looking at 0004, I think IsIndexCompatibleAsArbiter() should map the
> > attribute numbers, in case the partition has a different column layout
> > than the parent (e.g. in case there are dropped columns or just
> > different column orders)
>
> Oh, yes, you're right. I'll prepare an updated version (also it looks
> like some inner loops may be refactored in a more effective way).
I was wrong, function is called only for indexes from the same
relation (actual partition).
But anyway I reworked the commit - it is much clearer now (and a
little bit more effective).
Best regards,
Mikhail.
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0005-Revert-Doc-cover-index-CONCURRENTLY-causing-erro.patch | text/plain | 1.9 KB |
| v15-0004-Modify-the-ExecInitPartitionInfo-function-to-con.patch | text/plain | 18.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-11-30 16:58:01 | Re: Feature Proposal: schema renaming in pg_dump/pg_restore |
| Previous Message | Brad Arndt | 2025-11-30 14:45:37 | Feature Proposal: schema renaming in pg_dump/pg_restore |