From: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | [Code Cleanup] : Small code cleanup in twophase.sql |
Date: | 2023-09-26 13:01:42 |
Message-ID: | CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
PFA small code cleanup in twophase.sql. Which contains a drop table
statement for 'test_prepared_savepoint'. Which, to me, appears to be
missing in the cleanup section of that file.
To support it I have below points:-
1) Grepping this table 'test_prepared_savepoint' shows occurrences
only in twophase.out & twophase.sql files. This means that table is
local to that sql test file and not used in any other test file.
2) I don't see any comment on why this was not added in the cleanup
section of twophase.sql, but drop for other two test tables are done.
3) I ran "make check-world" with the patch and I don't see any failures.
Kindly correct, if I missed anything.
Regards,
Nishant (EDB).
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Small-code-cleanup-in-twophase.sql.patch | application/octet-stream | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2023-09-26 13:05:44 | Re: Correct the documentation for work_mem |
Previous Message | Fabrízio de Royes Mello | 2023-09-26 13:00:08 | Re: Add test module for Table Access Method |