Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions
Date: 2025-11-21 22:18:59
Message-ID: CADkLM=eidRg5VnDEPTK1y6QU1PB8QuzOB3xrsm0_X7DO2s984A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> > The same logic applies to RangeVarGetRelidExtendedSafe() and
> > makeRangeVarFromNameListSafe. These can be called from
> > RangeVarGetRelidExtended() and makeRangeVarFromNameList(),
> > respectively.
> > --
> >
>
> I don’t see any way to pass the escontext (ErrorSaveContext) without
> changing
> the textToQualifiedNameList function signature.
> ...
> Am I missing something?
>

I think we need to keep these separate. The execution paths that don't care
about capturing errors shouldn't be slowed down by minority of paths that
do. That may change in the future, but if it does, we'll be getting rid of
a lot of internal functions with this type of difference.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2025-11-21 22:26:52 Re: [PATCH] Allow complex data for GUC extra.
Previous Message Andrew Dunstan 2025-11-21 22:16:33 Re: meson and check-tests