Invalid remote sampling test in postgres_fdw.

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Invalid remote sampling test in postgres_fdw.
Date: 2025-08-11 14:23:47
Message-ID: CADkLM=cpUiJ3QF7aUthTvaVMmgQcm7QqZBRMDLhBRTR+gJX-Og@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Patch 0001 concerns what appears to be a bug in the postgres_fdw regression
tests.

As it was, the tests set the sampling method for the foreign server, but
rather than analyzing a table on that foreign server, the local table
analyze_table was analyzed instead.

The analyze commands now analyze a remote table, and the remote table
definition links it to the local table that was previously being analyzed
repeatedly.

Patch 0002 isn't a bug, just an annoyance.

It creates two psql variables which can then be interpolated into SQL
commands as string literals, eliminating the need to wrap commands in a DO
block. This makes the queries a bit more readable, and allows for any
errors (however unlikely) in those commands to be reported individually,
rather than grouped and potentially obfuscated by the DO block.

Attachment Content-Type Size
v1-0001-Fix-remote-sampling-tests-in-postgres_fdw.patch text/x-patch 3.6 KB
v1-0002-Use-psql-vars-to-eliminate-the-need-for-DO-blocks.patch text/x-patch 7.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2025-08-11 14:49:36 Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Previous Message Antonin Houska 2025-08-11 14:22:00 Re: Adding REPACK [concurrently]