| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Treat <rob(at)xzilla(dot)net>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2025-08-11 14:22:00 |
| Message-ID: | 41104.1754922120@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
> One more thing - I think build_new_indexes and
> index_concurrently_create_copy are very close in semantics, so it
> might be a good idea to refactor them a bit.
You're right. I think I even used the latter for reference when writing the
first.
0002 in the attached series tries to fix that. build_new_indexes() (in 0004)
is simpler now.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0001-Add-REPACK-command.patch | text/x-diff | 95.8 KB |
| v18-0002-Refactor-index_concurrently_create_copy-for-use-with.patch | text/x-diff | 4.1 KB |
| v18-0003-Move-conversion-of-a-historic-to-MVCC-snapshot-to-a-.patch | text/x-diff | 5.4 KB |
| v18-0004-Add-CONCURRENTLY-option-to-REPACK-command.patch | text/plain | 147.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-08-11 14:23:47 | Invalid remote sampling test in postgres_fdw. |
| Previous Message | Alexander Borisov | 2025-08-11 14:21:04 | Re: Improve the performance of Unicode Normalization Forms. |