Re: Extended Statistics set/restore/clear functions.

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: Extended Statistics set/restore/clear functions.
Date: 2025-11-05 06:38:56
Message-ID: CADkLM=cTVN3g7OzdSXfnBHEYNVQiGMJ8cdx1v=zJa86w1A9ULA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> Otherwise users may not benefit from this pg_upgrade feature for a
> couple more years. Plenty of users delay upgrading until the EOL gets
> close, and so might be unable to dump/restore extended stats for the
> next ~5 years

Paquier's response got sidetracked because of an errant subject line
change, so I will try to recap:

* pg_dump code changes no longer seem as bad on second look
* proceed with breakout per off-list discussion

in that off-list discussion I proposed (though I was mostly echoing what I
thought Paquier wanted):

1. pg_ndistinct output function change.
2. pg_ndistinct input function addition.
3. pg_dependencies output function change
4. pg_dependencies input function
5. Expose attribute statistics function and rename them attstat_* or
statatt_* (edit: and fix lack of comments on the enums and arrays)
6. pg_restore_extended_stats
7. pg_dump with no ability to fetch old-format pg_ndistinct/pg_dependences.
(edit: and fix inherited bug)
8. pg_dump working back as far as possible

Given that the pg_dump code no longer seems as bad, and Tomas is very much
in support of it, I've opted not to split out steps 7/8.

Attachment Content-Type Size
v5-0001-Refactor-output-format-of-pg_ndistinct.patch text/x-patch 13.8 KB
v5-0002-Add-working-input-function-for-pg_ndistinct.patch text/x-patch 16.5 KB
v5-0003-Refactor-output-format-of-pg_dependencies.patch text/x-patch 9.7 KB
v5-0004-Add-working-input-function-for-pg_dependencies.patch text/x-patch 18.0 KB
v5-0005-Expose-attribute-statistics-functions-for-use-in-.patch text/x-patch 11.2 KB
v5-0006-Add-extended-statistics-support-functions.patch text/x-patch 113.1 KB
v5-0007-Include-Extended-Statistics-in-pg_dump.patch text/x-patch 13.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-11-05 06:50:27 Re: [PATCH] Fix fragile walreceiver test.
Previous Message Alexander Pyhalov 2025-11-05 06:30:59 Re: Asynchronous MergeAppend