Re: Re: Add generate_series(date, date) and generate_series(date, date, integer)

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: Add generate_series(date, date) and generate_series(date, date, integer)
Date: 2016-02-02 18:20:01
Message-ID: CADkLM=cOf=QKy-KQ0GKvNko8yNdUb=xMKr7xnx7zsDaLhSnHFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
> > Do you have any insight as to why the documentation test failed?
> >
> > In the mean time, here's the updated patch.
>
> I didn't pass the docs on account of the wonky comment since I consider
> code comments to be part of the docs. The sgml docs build fine and look
> good to me.
>
>
Ah, understood. I rebuilt the docs thinking there was a make check failure
I missed, then viewed the html in links (I develop on an AWS box) and saw
nothing untoward.

> I'll retest and update the review accordingly.
>

Thanks!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-02-02 18:31:22 Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan
Previous Message David Steele 2016-02-02 18:08:16 Re: Re: Add generate_series(date, date) and generate_series(date, date, integer)