| From: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SendRowDescriptionMessage() is slow for queries with a lot of columns |
| Date: | 2017-09-20 06:18:13 |
| Message-ID: | CAD__OuhLJ0_11nDasytRibfPQwsXLXbcdx9OyMSCRfRtV9Dp6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 18, 2017 at 1:38 PM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> wrote:
> On Sat, Sep 16, 2017 at 3:03 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> So I think performance gain is visible. We saved a good amount of
> execution cycle in SendRowDescriptionMessagewhen(my callgrind report
> confirmed same) when we project a large number of columns in the query
> with these new patches.
I have tested patch, for me, patch looks good and can see improvement
in performance as a number of columns projected increases in the
query. There appear some cosmetic issues(pgindent issues + end of file
cr) in the patch if it can be considered as a valid issue they need
changes. Rest look okay for me.
--
Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-09-20 06:18:25 | Re: psql - add ability to test whether a variable exists |
| Previous Message | Gaddam Sai Ram | 2017-09-20 06:14:24 | Re: Error: dsa_area could not attach to a segment that has been freed |