From: | Dave Cramer <davecramer(at)gmail(dot)com> |
---|---|
To: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, nathandbossart(at)gmail(dot)com |
Subject: | Re: Using defines for protocol characters |
Date: | 2023-08-03 21:22:51 |
Message-ID: | CADK3HHLtFuq8PDsV0+ryoqpSxnnPVrS752q5ra9QZ-SiLqVUXg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 3 Aug 2023 at 13:25, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
> > Greetings,
> >
> > Attached is a patch which introduces a file protocol.h. Instead of using
> > the actual characters everywhere in the code this patch names the
> > characters and removes the comments beside each usage.
>
> > +#define DESCRIBE_PREPARED 'S'
> > +#define DESCRIBE_PORTAL 'P'
>
> You use these for Close message as well. I don't like the idea because
> Close is different message from Describe message.
>
> What about adding following for Close too use them instead?
>
> #define CLOSE_PREPARED 'S'
> #define CLOSE_PORTAL 'P'
>
Good catch.
I recall when writing this it was a bit hacky.
What do you think of PREPARED_SUB_COMMAND and PORTAL_SUB_COMMAND instead
of duplicating them ?
Dave
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2023-08-03 21:28:51 | Re: Fix incorrect start up costs for WindowAgg paths (bug #17862) |
Previous Message | Daniel Gustafsson | 2023-08-03 21:08:27 | Re: Track Oldest Initialized WAL Buffer Page |