| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-13 13:11:43 |
| Message-ID: | CADK3HHLmbnRSCfE0PoBjNdgZiep+o-frxBUFfywPcRb=TgFs9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 11 Jul 2020 at 10:20, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
> > On 11/07/2020 14:14, Dave Cramer wrote:
> >> So is there any point in having them as options then ?
>
> > I am guessing this is copied from pglogical, right? We have them there
> > because it can optionally send data in the on-disk format (not the
> > network binary format) and there this matters, but for network binary
> > format they do not matter as Tom says.
>
> Ah, I wondered why that was there at all. Yes, you should just delete
> all that logic --- it's irrelevant as long as we use the send/recv
> functions.
>
> regards, tom lane
>
Ok,
removed all the unnecessary options.
Added the test case that Daniel had created.
Added a note to the docs.
Note WAL_DEBUG is removed in patch 3. I could rebase that into patch 1 if
required.
Thanks,
Dave
| Attachment | Content-Type | Size |
|---|---|---|
| 0003-Actually-set-the-default-to-unchanged-as-per-the-com.patch | application/octet-stream | 14.3 KB |
| 0002-document-new-binary-option-for-CREATE-SUBSCRIPTION.patch | application/octet-stream | 3.1 KB |
| 0004-Add-psql-support-and-tests.patch | application/octet-stream | 8.7 KB |
| 0001-Add-binary-protocol-for-publications-and-subscriptio.patch | application/octet-stream | 38.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-07-13 13:13:42 | Re: Default setting for enable_hashagg_disk |
| Previous Message | Michael Paquier | 2020-07-13 12:52:12 | Re: Editing errors in the comments of tableam.h and heapam.c |