Re: Editing errors in the comments of tableam.h and heapam.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Hironobu SUZUKI <hironobu(at)interdb(dot)jp>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Editing errors in the comments of tableam.h and heapam.c
Date: 2020-07-13 12:52:12
Message-ID: 20200713125212.GC10826@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 13, 2020 at 02:25:39PM +0200, Hironobu SUZUKI wrote:
> Some comments in tableam.h and heapam.c contain three old function names
> although these have been renamed by this commit
> 73b8c3bd2889fed986044e15aefd0911f96ccdd3.
>
> Old: table_insert, table_fetch_row_version, table_get_latest_tid.
>
> New: table_tuple_insert, table_tuple_fetch_row_version,
> table_tuple_get_latest_tid.

Thanks. That looks right.

> I think these are editing errors. PG 12 also has the same errors.

Yeah. We also recommend to look at tableam.h in the docs, so while
usually I just bother fixing comments on HEAD, it would be better to
back-patch this one.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2020-07-13 13:11:43 Re: Binary support for pgoutput plugin
Previous Message Alexander Korotkov 2020-07-13 12:44:45 Re: output columns of \dAo and \dAp