| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2019-11-11 17:07:20 |
| Message-ID: | CADK3HHKvgfbeKYAHB-=Z1sNCysyeikSnhJHgKhcX+aNoOyGXXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 11 Nov 2019 at 12:04, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> On 2019-Nov-11, Dave Cramer wrote:
>
> > Previously someone mentioned that we need to confirm whether the two
> > servers are compatible for binary or not.
> >
> > Checking to make sure the two servers have the same endianness is
> obvious.
> > Sizeof int, long, float, double, timestamp (float/int) at a minimum.
> >
> > this could be done in libpqrcv_startstreaming. The question I have
> > remaining is do we fall back to text mode if needed or simply fail ?
>
> I think it makes more sense to have it fail. If the user wants to retry
> in text mode, they can do that easily enough; but if we make it
> fall-back automatically and they set up the received wrongly by mistake,
> they would pay the performance penalty without noticing.
>
>
Alvaro,
thanks, after sending this I pretty much came to the same conclusion.
Dave
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-11-11 17:22:54 | Re: Why overhead of SPI is so large? |
| Previous Message | Alvaro Herrera | 2019-11-11 16:55:59 | Re: Binary support for pgoutput plugin |