Re: Request for comment on setting binary format output per session

From: Dave Cramer <davecramer(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Request for comment on setting binary format output per session
Date: 2023-03-26 21:54:05
Message-ID: CADK3HHJYXYjjxCC_Gimbw9avTVLBhb5QkyT-1_F2UEZQyYq70w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 26 Mar 2023 at 14:00, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:

> On Sat, 2023-03-25 at 19:58 -0400, Dave Cramer wrote:
> > Well that means that connection poolers have to all be fixed. There
> > are more than just pgbouncer.
> > Seems rather harsh that a new feature breaks a connection pooler or
> > makes the pooler unusable.
>
> Would it actually break connection poolers as they are now? Or would,
> for example, pgbouncer just not set the binary_format parameter on the
> outbound connection, and therefore just return everything as text until
> they add support to configure it?
>

Well I was presuming that they would just pass the parameter on. If they
didn't then binary_format won't work with them. In the case that they do
pass it on, then DISCARD_ALL will reset it and future borrows of the
connection will have no way to set it again; effectively making this a one
time setting.

So while it may not break them it doesn't seem like it is a very useful
solution.

Dave

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2023-03-26 22:05:44 Re: Time to move pg_test_timing to measure in nanoseconds
Previous Message Melanie Plageman 2023-03-26 21:42:45 Re: refactoring relation extension and BufferAlloc(), faster COPY