| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2019-11-05 12:16:10 |
| Message-ID: | CADK3HH+DjY+rFDtZKLd-WTL6kat6eSW8D56+L81Tj0YjHJroPg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 3 Nov 2019 at 21:47, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> > Ok, I've rebased and reverted logicalrep_read_insert
>
> Hi Dave,
>
> From the code style police (actually just from cfbot, which is set up
> to complain about declarations after statements, a bit of C99 we
> aren't ready for):
>
> proto.c:557:6: error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
> int len = pq_getmsgint(in, 4); /* read length */
> ^
> proto.c:573:6: error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
> int len = pq_getmsgint(in, 4); /* read length */
> ^
>
Thomas,
Thanks for the review.
See attached
| Attachment | Content-Type | Size |
|---|---|---|
| 0005-Remove-C99-declaration-and-code.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2019-11-05 12:51:27 | Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status) |
| Previous Message | Alexey Bashtanov | 2019-11-05 12:07:50 | Re: log bind parameter values on error |