From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Dave Cramer <davecramer(at)gmail(dot)com> |
Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Binary support for pgoutput plugin |
Date: | 2019-11-04 02:46:49 |
Message-ID: | CA+hUKGKC=Yu6ZG0=K4R++7pEgj5zJgMqsVbuoHjLUjVLXBoPZA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> Ok, I've rebased and reverted logicalrep_read_insert
Hi Dave,
From the code style police (actually just from cfbot, which is set up
to complain about declarations after statements, a bit of C99 we
aren't ready for):
proto.c:557:6: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
int len = pq_getmsgint(in, 4); /* read length */
^
proto.c:573:6: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
int len = pq_getmsgint(in, 4); /* read length */
^
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-11-04 03:53:00 | TAP tests aren't using the magic words for Windows file access |
Previous Message | Thomas Munro | 2019-11-04 02:42:39 | Re: New SQL counter statistics view (pg_stat_sql) |