Table collision in join.sql and aggregates.sql

From: Douglas Doole <dougdoole(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Table collision in join.sql and aggregates.sql
Date: 2017-03-31 22:46:57
Message-ID: CADE5jYK45Nh5x5fogr0G6wLhUCUuO9mWXaUfY3Kr83p9R+MLBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

As we've been merging our code with 9.6, a couple developers have had
one-off failures in the join.sql and aggregates.sql test because the tables
T1, T2 and T3 have the wrong definitions.

Digging into it, I found that both files create the tables T1, T2, and T3
for a short period of time and then drop them. Since the parallel_schedule
file puts these two files into the same group, they can run concurrently.
If it happens that the the two files hit the T1, T2, T3 tests at the same
time, then you see the table definition problems.

I took the easy way of solving this and renamed the tables in
aggregates.sql to AGG1, AGG2, and AGG3. (Picked on aggregates.sql since it
had the T1, T2, T3 tests added in 9.6.)

Doug
- Salesforce

Attachment Content-Type Size
aggregates.patch text/x-patch 7.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-03-31 22:52:37 Re: Somebody has not thought through subscription locking considerations
Previous Message Petr Jelinek 2017-03-31 22:44:17 Re: Somebody has not thought through subscription locking considerations