Re: Table collision in join.sql and aggregates.sql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Douglas Doole <dougdoole(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Table collision in join.sql and aggregates.sql
Date: 2017-03-31 23:01:24
Message-ID: 11413.1491001284@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Douglas Doole <dougdoole(at)gmail(dot)com> writes:
> As we've been merging our code with 9.6, a couple developers have had
> one-off failures in the join.sql and aggregates.sql test because the tables
> T1, T2 and T3 have the wrong definitions.

> Digging into it, I found that both files create the tables T1, T2, and T3
> for a short period of time and then drop them. Since the parallel_schedule
> file puts these two files into the same group, they can run concurrently.
> If it happens that the the two files hit the T1, T2, T3 tests at the same
> time, then you see the table definition problems.

Hmmm ... that would indeed be a problem, except that aggregate.sql's
tables are temp tables, which should mean that they are in a schema
different from the one that join.sql is putting its tables in. Are you
sure you've identified the issue correctly? Because if this doesn't
work, there are an awful lot of similar hazards elsewhere in the
regression tests.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-03-31 23:19:04 Re: postgres_fdw IMPORT SCHEMA and partitioned tables
Previous Message Petr Jelinek 2017-03-31 23:00:38 Re: Somebody has not thought through subscription locking considerations