Re: Add a hook for handling logical decoding messages on subscribers.

On Thu, Nov 12, 2026 at 2:06 AM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> Hi,
>
> Sorry for joining this discussion so late.
>
> On Thu, Nov 12, 2026 at 03:02:44PM +0530, Amit Kapila wrote:
> > On Thu, Nov 12, 2026 at 4:10 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > On Mon, Nov 9, 2026 at 5:21 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > > >
> > > > I've attached the new patches. I just updated the commit message for
> > > > the 0001 patch, and added some fixes and regression tests for the 0002
> > > > patch. Please review them.
> > >
> > > I think the 0001 patch can be pushed independently. So I'm going to
> > > push it to master, barring objections.
> > >
> >
> > Few comments on 0001:
> > * As we are planning this as a master-only change, will it be better
> > if we just pass subxid as a separate parameter to keep the interface
> > consistent with other similar interfaces and avoid the need for
> > plugins to retrieve toptxn separately.
>
> +1. That would also prevent the crash mentioned in the commit message, as txn
> would remain the top level transaction.
>
> Regards,

Agreed. It's better for callbacks to get both top-level and
subtransaction's ids.

I've updated the patches (the 0002 patch unchanged).

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com