| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-11-25 12:30:11 |
| Message-ID: | CAD21AoDKhBWhZ2oNPGFKktJhX=AMGMtBMTOi1N3OkdOh5cjMBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 25, 2021 at 9:08 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Wed, Nov 24, 2021 at 10:44 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached an updated version patch. Unless I miss something, all
> > comments I got so far have been incorporated into this patch. Please
> > review it.
> >
>
> Only a couple of minor points:
>
> src/backend/postmaster/pgstat.c
> (1) pgstat_get_subworker_entry
>
> In the following comment, it should say "returns an entry ...":
>
> + * apply worker otherwise returns entry of the table sync worker associated
>
> src/include/pgstat.h
> (2) typedef struct PgStat_StatDBEntry
>
> "subworker" should be "subworkers" in the following comment, to match
> the struct member name:
>
> * subworker is the hash table of PgStat_StatSubWorkerEntry which stores
>
> Otherwise, the patch LGTM.
Thank you for the comments! These are incorporated into v25 patch I
just submitted.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-11-25 13:05:43 | RE: Skipping logical replication transactions on subscriber side |
| Previous Message | Masahiko Sawada | 2021-11-25 12:29:45 | Re: Skipping logical replication transactions on subscriber side |