Re: pgbench: Skipping the creating primary keys after initialization

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench: Skipping the creating primary keys after initialization
Date: 2017-09-08 00:52:48
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On Thu, Sep 7, 2017 at 4:15 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>>> Very very minor comments that I should have noticed before, sorry for
>>> this
>>> additional round trip.
>> Thank you for the dedicated review!
> I'm someone at times pigheaded, I think in the good sense if it is possible,
> and I like to finish what I start:-)
> Patch applies, compiles, works, everything is fine from my point of view.
> I switched it to "Ready for Committer".


> Again, if the pgbench tap test patch get through, it should be tap tested.

Thank you for the remainder, I'll add tap tests once the patch got committed.


Masahiko Sawada
NTT Open Source Software Center

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-09-08 01:07:07 Re: GSoC 2017: weekly progress reports (week 4) and patch for hash index
Previous Message Simon Riggs 2017-09-08 00:49:00 Re: [bug fix] Savepoint-related statements terminates connection