Re: pgbench: Skipping the creating primary keys after initialization

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench: Skipping the creating primary keys after initialization
Date: 2017-09-07 07:15:05
Message-ID: alpine.DEB.2.20.1709070909580.22058@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> Very very minor comments that I should have noticed before, sorry for this
>> additional round trip.
>
> Thank you for the dedicated review!

I'm someone at times pigheaded, I think in the good sense if it is
possible, and I like to finish what I start:-)

Patch applies, compiles, works, everything is fine from my point of view.

I switched it to "Ready for Committer".

Again, if the pgbench tap test patch get through, it should be tap tested.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Travers 2017-09-07 07:21:21 Re: Proposal: pg_rewind to skip config files
Previous Message Tatsuro Yamada 2017-09-07 06:46:03 Re: CLUSTER command progress monitor