| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ethan Mertz <ethan(dot)mertz(at)gmail(dot)com> |
| Subject: | Re: Use-after-free in reorderbuffer.c for INSERT ON CONFLICT |
| Date: | 2025-07-31 16:51:21 |
| Message-ID: | CAD21AoD7J9YNZ0uoxWJyxxQtYbZXNKD6k_52-Ww2P3vw-67c7Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Jul 30, 2025 at 11:44 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> A simple solution suggested by Ethan would be to use the "prev_lsn"
> guessed from the change at the beginning of the loop, rather than the
> problematic change->lsn. But that does not seem completely right to
> me because we can switch to "specinsert" as the change to process,
> hence wouldn't we want to call update_progress_txn() based on the LSN
> of the actual change we are looking at? All that leads me to the
> attached.
Thank you for preparing the patch!
Yes, I think it's sensible to keep the current behavior. So the patch
looks good to me.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-07-31 18:17:35 | Re: BUG #19000: gist index returns inconsistent result with gist_inet_ops |
| Previous Message | Peter Eisentraut | 2025-07-31 15:43:18 | Re: BUG #19000: gist index returns inconsistent result with gist_inet_ops |