Re: pgsql: Use FullTransactionId for the transaction stack.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use FullTransactionId for the transaction stack.
Date: 2019-03-28 10:51:23
Message-ID: CAD21AoD-qw83u8XaLYvrmEoLQipm0YRrFRFBYfwA=sVUgj7wMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Mar 28, 2019 at 2:27 PM Thomas Munro <tmunro(at)postgresql(dot)org> wrote:
>
> Use FullTransactionId for the transaction stack.
>
> Provide GetTopFullTransactionId() and GetCurrentFullTransactionId().
> The intended users of these interfaces are access methods that use
> xids for visibility checks but don't want to have to go back and
> "freeze" existing references some time later before the 32 bit xid
> counter wraps around.
>
> Use a new struct to serialize the transaction state for parallel
> query, because FullTransactionId doesn't fit into the previous
> serialization scheme very well.
>
> Author: Thomas Munro
> Reviewed-by: Heikki Linnakangas
> Discussion: https://postgr.es/m/CAA4eK1%2BMv%2Bmb0HFfWM9Srtc6MVe160WFurXV68iAFMcagRZ0dQ%40mail.gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/ad308058cc8666c50b43179e64d6bb7aeb3ba169
>
> Modified Files
> --------------
> src/backend/access/transam/varsup.c | 13 +-
> src/backend/access/transam/xact.c | 229 ++++++++++++++++++++++++------------
> src/include/access/transam.h | 3 +-
> src/include/access/xact.h | 5 +
> src/tools/pgindent/typedefs.list | 1 +
> 5 files changed, 170 insertions(+), 81 deletions(-)
>

/*
+ * Serialized representation used to transmit transaction state to parallel
+ * workers though shared memory.

The second line of the above comment must be "workers *through* shared
memory"? Attached the patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
fix_typo.patch application/octet-stream 464 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-03-28 12:28:47 Re: pgsql: Compute XID horizon for page level index vacuum on primary.
Previous Message Tomas Vondra 2019-03-28 09:30:46 Re: pgsql: Add support for multivariate MCV lists