Re: [PG19] Promotion hangs behind a backend blocked on a stuck client

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Manu <manuelreyesbravo(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: [PG19] Promotion hangs behind a backend blocked on a stuck client
Date: 2026-10-27 22:45:16
Message-ID: CAD21AoCmeDH=yeL6iY2fGaHJuGz=8332=iD+inNyZA_-0e3dAQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 23, 2026 at 10:17 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Oct 22, 2026 at 2:07 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Oct 22, 2026 at 12:23 PM Hayato Kuroda (Fujitsu)
> > <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> > >
> > > > Okay, PFA the patch with comments addressed.
> > >
> > > ```
> > > + <literal>replica</literal> that has a valid (not invalidated) logical
> > > ```
> > >
> > > We have already had a term "valid replication slot", in protocol.sgml. So I think
> > > the part () may not be needed. Please use v3 if it's acceptable.
> > >
> >
> > LGTM. Sawada-San, feel free to review and push.
>
> Thank you for creating and reviewing the patch. The patch looks good
> to me too. I'll push it on early next week.

Pushed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message surya poondla 2026-10-27 22:50:07 Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed
Previous Message Zsolt Parragi 2026-10-27 22:30:47 Re: [PROPOSAL] Expand OR clauses in joins to UNION ALL paths