| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Manu <manuelreyesbravo(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Date: | 2026-10-24 05:17:49 |
| Message-ID: | CAD21AoD28TDt5i+Br6fi+OMhCdyCGkxmw3Yy_gsR3KRxLAOwTA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 22, 2026 at 2:07 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Oct 22, 2026 at 12:23 PM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > > Okay, PFA the patch with comments addressed.
> >
> > ```
> > + <literal>replica</literal> that has a valid (not invalidated) logical
> > ```
> >
> > We have already had a term "valid replication slot", in protocol.sgml. So I think
> > the part () may not be needed. Please use v3 if it's acceptable.
> >
>
> LGTM. Sawada-San, feel free to review and push.
Thank you for creating and reviewing the patch. The patch looks good
to me too. I'll push it on early next week.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-24 05:25:30 | Re: Return pg_control from pg_backup_stop(). |
| Previous Message | shihao zhong | 2026-10-24 05:04:47 | Re: Assertion failure in WAL summarizer |