Re: [DOC] Update ALTER SUBSCRIPTION documentation

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Sjöblom <robert(dot)sjoblom(at)fortnox(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [DOC] Update ALTER SUBSCRIPTION documentation
Date: 2023-05-09 08:14:35
Message-ID: CAD21AoCksS17ERVg6_A0Oxf7X=CGYAf9jm7Z0YRCP7OF1GFAEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 9, 2023 at 3:40 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, May 8, 2023 at 1:51 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Apart from the documentation change, given that setting slot_name =
> > NONE always requires for the subscription to be disabled beforehand,
> > does it make sense to change ALTER SUBSCRIPTION SET so that we disable
> > the subscription when setting slot_name = NONE? Setting slot_name to a
> > valid slot name doesn't enable the subscription, though.
> >
>
> I think this is worth considering. Offhand, I don't see any problem
> with this idea but users may not like the automatic disabling of
> subscriptions along with setting slot_name=NONE. It would be better to
> discuss this in a separate thread to seek the opinion of others.
>

Agreed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-05-09 08:25:53 Re: Order changes in PG16 since ICU introduction
Previous Message Alvaro Herrera 2023-05-09 08:01:38 Re: Improve list manipulation in several places