| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Robert Sjöblom <robert(dot)sjoblom(at)fortnox(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [DOC] Update ALTER SUBSCRIPTION documentation |
| Date: | 2023-05-09 06:40:11 |
| Message-ID: | CAA4eK1K0AZeux0XmqhX77Q339A0=bov1meYFSvEaqHmBcFmG-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 8, 2023 at 1:51 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Apart from the documentation change, given that setting slot_name =
> NONE always requires for the subscription to be disabled beforehand,
> does it make sense to change ALTER SUBSCRIPTION SET so that we disable
> the subscription when setting slot_name = NONE? Setting slot_name to a
> valid slot name doesn't enable the subscription, though.
>
I think this is worth considering. Offhand, I don't see any problem
with this idea but users may not like the automatic disabling of
subscriptions along with setting slot_name=NONE. It would be better to
discuss this in a separate thread to seek the opinion of others.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2023-05-09 06:52:18 | psql tests hangs |
| Previous Message | Michael Paquier | 2023-05-09 06:25:29 | Re: WAL Insertion Lock Improvements |